Skip to content

Add powi fo f16 and f128 #125188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2024
Merged

Add powi fo f16 and f128 #125188

merged 2 commits into from
May 17, 2024

Conversation

tgross35
Copy link
Contributor

This will unblock adding support to compiler_builtins (rust-lang/compiler-builtins#614), which will then unblock adding tests for these new functions.

tgross35 added 2 commits May 16, 2024 15:16
@tgross35
Add doctests for f16 and f128 library functions where possible
a7ca099
@tgross35
Add powi to f16 and f128
7685734 
This will unblock adding support to compiler_builtins
(<rust-lang/compiler-builtins#614>), which will
then unblock adding tests for these new functions.
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2024
@tgross35 tgross35 mentioned this pull request May 16, 2024
Closed
@tgross35
Copy link
Contributor Author

@rustbot label +F-f16_and_f128

@rustbot rustbot added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label May 16, 2024
@tgross35
Copy link
Contributor Author

r? @joboet since you were on the other PR before I switched the branch

@rustbot rustbot assigned joboet and unassigned Mark-Simulacrum May 16, 2024
@tgross35 tgross35 mentioned this pull request May 16, 2024
Merged
@joboet
Copy link
Member

joboet commented May 17, 2024

Sorry, this is absolutely not my area of expertise.
r? libs

@rustbot rustbot assigned Noratrieb and unassigned joboet May 17, 2024
@Noratrieb
Copy link
Member

@bors r+ rollup looks good

@bors
Copy link
Collaborator

bors commented May 17, 2024

📌 Commit 7685734 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2024
@bors
Copy link
Collaborator

bors commented May 17, 2024

⌛ Testing commit 7685734 with merge ddba1dc...

@bors
Copy link
Collaborator

bors commented May 17, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing ddba1dc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2024
@bors bors merged commit ddba1dc into rust-lang:master May 17, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 17, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ddba1dc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Cycles

Results (primary -0.2%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 6.1% [6.1%, 6.1%] 1
Regressions ❌
(secondary)		 2.2% [1.8%, 2.9%] 4
Improvements ✅
(primary)		 -3.3% [-3.9%, -2.8%] 2
Improvements ✅
(secondary)		 -2.4% [-3.3%, -1.5%] 5
All ❌✅ (primary) -0.2% [-3.9%, 6.1%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.422s -> 667.526s (-0.28%)
Artifact size: 316.04 MiB -> 316.05 MiB (0.00%)

@tgross35 tgross35 deleted the f16-f128-powi branch May 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tgross35 @rustbot @joboet @Noratrieb @bors @rust-timer @Mark-Simulacrum